fix(lint): resolve data management staticcheck warnings
This commit is contained in:
@@ -1,6 +1,7 @@
|
|||||||
package admin
|
package admin
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"context"
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
@@ -13,13 +14,34 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
type DataManagementHandler struct {
|
type DataManagementHandler struct {
|
||||||
dataManagementService *service.DataManagementService
|
dataManagementService dataManagementService
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewDataManagementHandler(dataManagementService *service.DataManagementService) *DataManagementHandler {
|
func NewDataManagementHandler(dataManagementService *service.DataManagementService) *DataManagementHandler {
|
||||||
return &DataManagementHandler{dataManagementService: dataManagementService}
|
return &DataManagementHandler{dataManagementService: dataManagementService}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type dataManagementService interface {
|
||||||
|
GetConfig(ctx context.Context) (service.DataManagementConfig, error)
|
||||||
|
UpdateConfig(ctx context.Context, cfg service.DataManagementConfig) (service.DataManagementConfig, error)
|
||||||
|
ValidateS3(ctx context.Context, cfg service.DataManagementS3Config) (service.DataManagementTestS3Result, error)
|
||||||
|
CreateBackupJob(ctx context.Context, input service.DataManagementCreateBackupJobInput) (service.DataManagementBackupJob, error)
|
||||||
|
ListSourceProfiles(ctx context.Context, sourceType string) ([]service.DataManagementSourceProfile, error)
|
||||||
|
CreateSourceProfile(ctx context.Context, input service.DataManagementCreateSourceProfileInput) (service.DataManagementSourceProfile, error)
|
||||||
|
UpdateSourceProfile(ctx context.Context, input service.DataManagementUpdateSourceProfileInput) (service.DataManagementSourceProfile, error)
|
||||||
|
DeleteSourceProfile(ctx context.Context, sourceType, profileID string) error
|
||||||
|
SetActiveSourceProfile(ctx context.Context, sourceType, profileID string) (service.DataManagementSourceProfile, error)
|
||||||
|
ListS3Profiles(ctx context.Context) ([]service.DataManagementS3Profile, error)
|
||||||
|
CreateS3Profile(ctx context.Context, input service.DataManagementCreateS3ProfileInput) (service.DataManagementS3Profile, error)
|
||||||
|
UpdateS3Profile(ctx context.Context, input service.DataManagementUpdateS3ProfileInput) (service.DataManagementS3Profile, error)
|
||||||
|
DeleteS3Profile(ctx context.Context, profileID string) error
|
||||||
|
SetActiveS3Profile(ctx context.Context, profileID string) (service.DataManagementS3Profile, error)
|
||||||
|
ListBackupJobs(ctx context.Context, input service.DataManagementListBackupJobsInput) (service.DataManagementListBackupJobsResult, error)
|
||||||
|
GetBackupJob(ctx context.Context, jobID string) (service.DataManagementBackupJob, error)
|
||||||
|
EnsureAgentEnabled(ctx context.Context) error
|
||||||
|
GetAgentHealth(ctx context.Context) service.DataManagementAgentHealth
|
||||||
|
}
|
||||||
|
|
||||||
type TestS3ConnectionRequest struct {
|
type TestS3ConnectionRequest struct {
|
||||||
Endpoint string `json:"endpoint"`
|
Endpoint string `json:"endpoint"`
|
||||||
Region string `json:"region" binding:"required"`
|
Region string `json:"region" binding:"required"`
|
||||||
|
|||||||
@@ -55,8 +55,7 @@ type DataManagementAgentInfo struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
type DataManagementService struct {
|
type DataManagementService struct {
|
||||||
socketPath string
|
socketPath string
|
||||||
dialTimeout time.Duration
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewDataManagementService() *DataManagementService {
|
func NewDataManagementService() *DataManagementService {
|
||||||
@@ -64,16 +63,13 @@ func NewDataManagementService() *DataManagementService {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func NewDataManagementServiceWithOptions(socketPath string, dialTimeout time.Duration) *DataManagementService {
|
func NewDataManagementServiceWithOptions(socketPath string, dialTimeout time.Duration) *DataManagementService {
|
||||||
|
_ = dialTimeout
|
||||||
path := strings.TrimSpace(socketPath)
|
path := strings.TrimSpace(socketPath)
|
||||||
if path == "" {
|
if path == "" {
|
||||||
path = DefaultDataManagementAgentSocketPath
|
path = DefaultDataManagementAgentSocketPath
|
||||||
}
|
}
|
||||||
if dialTimeout <= 0 {
|
|
||||||
dialTimeout = 500 * time.Millisecond
|
|
||||||
}
|
|
||||||
return &DataManagementService{
|
return &DataManagementService{
|
||||||
socketPath: path,
|
socketPath: path,
|
||||||
dialTimeout: dialTimeout,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user