From 1d1fc019dc1e942f60f3d2fffba7deaffd6bad1c Mon Sep 17 00:00:00 2001 From: yangjianbo Date: Sat, 28 Feb 2026 15:05:54 +0800 Subject: [PATCH] fix(lint): resolve data management staticcheck warnings --- .../handler/admin/data_management_handler.go | 24 ++++++++++++++++++- .../service/data_management_service.go | 10 +++----- 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/backend/internal/handler/admin/data_management_handler.go b/backend/internal/handler/admin/data_management_handler.go index 69a0b5b5..02fc766f 100644 --- a/backend/internal/handler/admin/data_management_handler.go +++ b/backend/internal/handler/admin/data_management_handler.go @@ -1,6 +1,7 @@ package admin import ( + "context" "strconv" "strings" @@ -13,13 +14,34 @@ import ( ) type DataManagementHandler struct { - dataManagementService *service.DataManagementService + dataManagementService dataManagementService } func NewDataManagementHandler(dataManagementService *service.DataManagementService) *DataManagementHandler { return &DataManagementHandler{dataManagementService: dataManagementService} } +type dataManagementService interface { + GetConfig(ctx context.Context) (service.DataManagementConfig, error) + UpdateConfig(ctx context.Context, cfg service.DataManagementConfig) (service.DataManagementConfig, error) + ValidateS3(ctx context.Context, cfg service.DataManagementS3Config) (service.DataManagementTestS3Result, error) + CreateBackupJob(ctx context.Context, input service.DataManagementCreateBackupJobInput) (service.DataManagementBackupJob, error) + ListSourceProfiles(ctx context.Context, sourceType string) ([]service.DataManagementSourceProfile, error) + CreateSourceProfile(ctx context.Context, input service.DataManagementCreateSourceProfileInput) (service.DataManagementSourceProfile, error) + UpdateSourceProfile(ctx context.Context, input service.DataManagementUpdateSourceProfileInput) (service.DataManagementSourceProfile, error) + DeleteSourceProfile(ctx context.Context, sourceType, profileID string) error + SetActiveSourceProfile(ctx context.Context, sourceType, profileID string) (service.DataManagementSourceProfile, error) + ListS3Profiles(ctx context.Context) ([]service.DataManagementS3Profile, error) + CreateS3Profile(ctx context.Context, input service.DataManagementCreateS3ProfileInput) (service.DataManagementS3Profile, error) + UpdateS3Profile(ctx context.Context, input service.DataManagementUpdateS3ProfileInput) (service.DataManagementS3Profile, error) + DeleteS3Profile(ctx context.Context, profileID string) error + SetActiveS3Profile(ctx context.Context, profileID string) (service.DataManagementS3Profile, error) + ListBackupJobs(ctx context.Context, input service.DataManagementListBackupJobsInput) (service.DataManagementListBackupJobsResult, error) + GetBackupJob(ctx context.Context, jobID string) (service.DataManagementBackupJob, error) + EnsureAgentEnabled(ctx context.Context) error + GetAgentHealth(ctx context.Context) service.DataManagementAgentHealth +} + type TestS3ConnectionRequest struct { Endpoint string `json:"endpoint"` Region string `json:"region" binding:"required"` diff --git a/backend/internal/service/data_management_service.go b/backend/internal/service/data_management_service.go index 83e939f4..b525c0fa 100644 --- a/backend/internal/service/data_management_service.go +++ b/backend/internal/service/data_management_service.go @@ -55,8 +55,7 @@ type DataManagementAgentInfo struct { } type DataManagementService struct { - socketPath string - dialTimeout time.Duration + socketPath string } func NewDataManagementService() *DataManagementService { @@ -64,16 +63,13 @@ func NewDataManagementService() *DataManagementService { } func NewDataManagementServiceWithOptions(socketPath string, dialTimeout time.Duration) *DataManagementService { + _ = dialTimeout path := strings.TrimSpace(socketPath) if path == "" { path = DefaultDataManagementAgentSocketPath } - if dialTimeout <= 0 { - dialTimeout = 500 * time.Millisecond - } return &DataManagementService{ - socketPath: path, - dialTimeout: dialTimeout, + socketPath: path, } }