* fix(ops): 修复运维监控系统的关键安全和稳定性问题
## 修复内容
### P0 严重问题
1. **DNS Rebinding防护** (ops_alert_service.go)
- 实现IP钉住机制防止验证后的DNS rebinding攻击
- 自定义Transport.DialContext强制只允许拨号到验证过的公网IP
- 扩展IP黑名单,包括云metadata地址(169.254.169.254)
- 添加完整的单元测试覆盖
2. **OpsAlertService生命周期管理** (wire.go)
- 在ProvideOpsMetricsCollector中添加opsAlertService.Start()调用
- 确保stopCtx正确初始化,避免nil指针问题
- 实现防御式启动,保证服务启动顺序
3. **数据库查询排序** (ops_repo.go)
- 在ListRecentSystemMetrics中添加显式ORDER BY updated_at DESC, id DESC
- 在GetLatestSystemMetric中添加排序保证
- 避免数据库返回顺序不确定导致告警误判
### P1 重要问题
4. **并发安全** (ops_metrics_collector.go)
- 为lastGCPauseTotal字段添加sync.Mutex保护
- 防止数据竞争
5. **Goroutine泄漏** (ops_error_logger.go)
- 实现worker pool模式限制并发goroutine数量
- 使用256容量缓冲队列和10个固定worker
- 非阻塞投递,队列满时丢弃任务
6. **生命周期控制** (ops_alert_service.go)
- 添加Start/Stop方法实现优雅关闭
- 使用context控制goroutine生命周期
- 实现WaitGroup等待后台任务完成
7. **Webhook URL验证** (ops_alert_service.go)
- 防止SSRF攻击:验证scheme、禁止内网IP
- DNS解析验证,拒绝解析到私有IP的域名
- 添加8个单元测试覆盖各种攻击场景
8. **资源泄漏** (ops_repo.go)
- 修复多处defer rows.Close()问题
- 简化冗余的defer func()包装
9. **HTTP超时控制** (ops_alert_service.go)
- 创建带10秒超时的http.Client
- 添加buildWebhookHTTPClient辅助函数
- 防止HTTP请求无限期挂起
10. **数据库查询优化** (ops_repo.go)
- 将GetWindowStats的4次独立查询合并为1次CTE查询
- 减少网络往返和表扫描次数
- 显著提升性能
11. **重试机制** (ops_alert_service.go)
- 实现邮件发送重试:最多3次,指数退避(1s/2s/4s)
- 添加webhook备用通道
- 实现完整的错误处理和日志记录
12. **魔法数字** (ops_repo.go, ops_metrics_collector.go)
- 提取硬编码数字为有意义的常量
- 提高代码可读性和可维护性
## 测试验证
- ✅ go test ./internal/service -tags opsalert_unit 通过
- ✅ 所有webhook验证测试通过
- ✅ 重试机制测试通过
## 影响范围
- 运维监控系统安全性显著提升
- 系统稳定性和性能优化
- 无破坏性变更,向后兼容
* feat(ops): 运维监控系统V2 - 完整实现
## 核心功能
- 运维监控仪表盘V2(实时监控、历史趋势、告警管理)
- WebSocket实时QPS/TPS监控(30s心跳,自动重连)
- 系统指标采集(CPU、内存、延迟、错误率等)
- 多维度统计分析(按provider、model、user等维度)
- 告警规则管理(阈值配置、通知渠道)
- 错误日志追踪(详细错误信息、堆栈跟踪)
## 数据库Schema (Migration 025)
### 扩展现有表
- ops_system_metrics: 新增RED指标、错误分类、延迟指标、资源指标、业务指标
- ops_alert_rules: 新增JSONB字段(dimension_filters, notify_channels, notify_config)
### 新增表
- ops_dimension_stats: 多维度统计数据
- ops_data_retention_config: 数据保留策略配置
### 新增视图和函数
- ops_latest_metrics: 最新1分钟窗口指标(已修复字段名和window过滤)
- ops_active_alerts: 当前活跃告警(已修复字段名和状态值)
- calculate_health_score: 健康分数计算函数
## 一致性修复(98/100分)
### P0级别(阻塞Migration)
- ✅ 修复ops_latest_metrics视图字段名(latency_p99→p99_latency_ms, cpu_usage→cpu_usage_percent)
- ✅ 修复ops_active_alerts视图字段名(metric→metric_type, triggered_at→fired_at, trigger_value→metric_value, threshold→threshold_value)
- ✅ 统一告警历史表名(删除ops_alert_history,使用ops_alert_events)
- ✅ 统一API参数限制(ListMetricsHistory和ListErrorLogs的limit改为5000)
### P1级别(功能完整性)
- ✅ 修复ops_latest_metrics视图未过滤window_minutes(添加WHERE m.window_minutes = 1)
- ✅ 修复数据回填UPDATE逻辑(QPS计算改为request_count/(window_minutes*60.0))
- ✅ 添加ops_alert_rules JSONB字段后端支持(Go结构体+序列化)
### P2级别(优化)
- ✅ 前端WebSocket自动重连(指数退避1s→2s→4s→8s→16s,最大5次)
- ✅ 后端WebSocket心跳检测(30s ping,60s pong超时)
## 技术实现
### 后端 (Go)
- Handler层: ops_handler.go(REST API), ops_ws_handler.go(WebSocket)
- Service层: ops_service.go(核心逻辑), ops_cache.go(缓存), ops_alerts.go(告警)
- Repository层: ops_repo.go(数据访问), ops.go(模型定义)
- 路由: admin.go(新增ops相关路由)
- 依赖注入: wire_gen.go(自动生成)
### 前端 (Vue3 + TypeScript)
- 组件: OpsDashboardV2.vue(仪表盘主组件)
- API: ops.ts(REST API + WebSocket封装)
- 路由: index.ts(新增/admin/ops路由)
- 国际化: en.ts, zh.ts(中英文支持)
## 测试验证
- ✅ 所有Go测试通过
- ✅ Migration可正常执行
- ✅ WebSocket连接稳定
- ✅ 前后端数据结构对齐
* refactor: 代码清理和测试优化
## 测试文件优化
- 简化integration test fixtures和断言
- 优化test helper函数
- 统一测试数据格式
## 代码清理
- 移除未使用的代码和注释
- 简化concurrency_cache实现
- 优化middleware错误处理
## 小修复
- 修复gateway_handler和openai_gateway_handler的小问题
- 统一代码风格和格式
变更统计: 27个文件,292行新增,322行删除(净减少30行)
* fix(ops): 运维监控系统安全加固和功能优化
## 安全增强
- feat(security): WebSocket日志脱敏机制,防止token/api_key泄露
- feat(security): X-Forwarded-Host白名单验证,防止CSRF绕过
- feat(security): Origin策略配置化,支持strict/permissive模式
- feat(auth): WebSocket认证支持query参数传递token
## 配置优化
- feat(config): 支持环境变量配置代理信任和Origin策略
- OPS_WS_TRUST_PROXY
- OPS_WS_TRUSTED_PROXIES
- OPS_WS_ORIGIN_POLICY
- fix(ops): 错误日志查询限流从5000降至500,优化内存使用
## 架构改进
- refactor(ops): 告警服务解耦,独立运行评估定时器
- refactor(ops): OpsDashboard统一版本,移除V2分离
## 测试和文档
- test(ops): 添加WebSocket安全验证单元测试(8个测试用例)
- test(ops): 添加告警服务集成测试
- docs(api): 更新API文档,标注限流变更
- docs: 添加CHANGELOG记录breaking changes
## 修复文件
Backend:
- backend/internal/server/middleware/logger.go
- backend/internal/handler/admin/ops_handler.go
- backend/internal/handler/admin/ops_ws_handler.go
- backend/internal/server/middleware/admin_auth.go
- backend/internal/service/ops_alert_service.go
- backend/internal/service/ops_metrics_collector.go
- backend/internal/service/wire.go
Frontend:
- frontend/src/views/admin/ops/OpsDashboard.vue
- frontend/src/router/index.ts
- frontend/src/api/admin/ops.ts
Tests:
- backend/internal/handler/admin/ops_ws_handler_test.go (新增)
- backend/internal/service/ops_alert_service_integration_test.go (新增)
Docs:
- CHANGELOG.md (新增)
- docs/API-运维监控中心2.0.md (更新)
* fix(migrations): 修复calculate_health_score函数类型匹配问题
在ops_latest_metrics视图中添加显式类型转换,确保参数类型与函数签名匹配
* fix(lint): 修复golangci-lint检查发现的所有问题
- 将Redis依赖从service层移到repository层
- 添加错误检查(WebSocket连接和读取超时)
- 运行gofmt格式化代码
- 添加nil指针检查
- 删除未使用的alertService字段
修复问题:
- depguard: 3个(service层不应直接import redis)
- errcheck: 3个(未检查错误返回值)
- gofmt: 2个(代码格式问题)
- staticcheck: 4个(nil指针解引用)
- unused: 1个(未使用字段)
代码统计:
- 修改文件:11个
- 删除代码:490行
- 新增代码:105行
- 净减少:385行
403 lines
11 KiB
Go
403 lines
11 KiB
Go
package admin
|
|
|
|
import (
|
|
"math"
|
|
"net/http"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/Wei-Shaw/sub2api/internal/pkg/response"
|
|
"github.com/Wei-Shaw/sub2api/internal/service"
|
|
"github.com/gin-gonic/gin"
|
|
)
|
|
|
|
// OpsHandler handles ops dashboard endpoints.
|
|
type OpsHandler struct {
|
|
opsService *service.OpsService
|
|
}
|
|
|
|
// NewOpsHandler creates a new OpsHandler.
|
|
func NewOpsHandler(opsService *service.OpsService) *OpsHandler {
|
|
return &OpsHandler{opsService: opsService}
|
|
}
|
|
|
|
// GetMetrics returns the latest ops metrics snapshot.
|
|
// GET /api/v1/admin/ops/metrics
|
|
func (h *OpsHandler) GetMetrics(c *gin.Context) {
|
|
metrics, err := h.opsService.GetLatestMetrics(c.Request.Context())
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to get ops metrics")
|
|
return
|
|
}
|
|
response.Success(c, metrics)
|
|
}
|
|
|
|
// ListMetricsHistory returns a time-range slice of metrics for charts.
|
|
// GET /api/v1/admin/ops/metrics/history
|
|
//
|
|
// Query params:
|
|
// - window_minutes: int (default 1)
|
|
// - minutes: int (lookback; optional)
|
|
// - start_time/end_time: RFC3339 timestamps (optional; overrides minutes when provided)
|
|
// - limit: int (optional; max 100, default 300 for backward compatibility)
|
|
func (h *OpsHandler) ListMetricsHistory(c *gin.Context) {
|
|
windowMinutes := 1
|
|
if v := c.Query("window_minutes"); v != "" {
|
|
if parsed, err := strconv.Atoi(v); err == nil && parsed > 0 {
|
|
windowMinutes = parsed
|
|
} else {
|
|
response.BadRequest(c, "Invalid window_minutes")
|
|
return
|
|
}
|
|
}
|
|
|
|
limit := 300
|
|
limitProvided := false
|
|
if v := c.Query("limit"); v != "" {
|
|
parsed, err := strconv.Atoi(v)
|
|
if err != nil || parsed <= 0 || parsed > 5000 {
|
|
response.BadRequest(c, "Invalid limit (must be 1-5000)")
|
|
return
|
|
}
|
|
limit = parsed
|
|
limitProvided = true
|
|
}
|
|
|
|
endTime := time.Now()
|
|
startTime := time.Time{}
|
|
|
|
if startTimeStr := c.Query("start_time"); startTimeStr != "" {
|
|
parsed, err := time.Parse(time.RFC3339, startTimeStr)
|
|
if err != nil {
|
|
response.BadRequest(c, "Invalid start_time format (RFC3339)")
|
|
return
|
|
}
|
|
startTime = parsed
|
|
}
|
|
if endTimeStr := c.Query("end_time"); endTimeStr != "" {
|
|
parsed, err := time.Parse(time.RFC3339, endTimeStr)
|
|
if err != nil {
|
|
response.BadRequest(c, "Invalid end_time format (RFC3339)")
|
|
return
|
|
}
|
|
endTime = parsed
|
|
}
|
|
|
|
// If explicit range not provided, use lookback minutes.
|
|
if startTime.IsZero() {
|
|
if v := c.Query("minutes"); v != "" {
|
|
minutes, err := strconv.Atoi(v)
|
|
if err != nil || minutes <= 0 {
|
|
response.BadRequest(c, "Invalid minutes")
|
|
return
|
|
}
|
|
if minutes > 60*24*7 {
|
|
minutes = 60 * 24 * 7
|
|
}
|
|
startTime = endTime.Add(-time.Duration(minutes) * time.Minute)
|
|
}
|
|
}
|
|
|
|
// Default time range: last 24 hours.
|
|
if startTime.IsZero() {
|
|
startTime = endTime.Add(-24 * time.Hour)
|
|
if !limitProvided {
|
|
// Metrics are collected at 1-minute cadence; 24h requires ~1440 points.
|
|
limit = 24 * 60
|
|
}
|
|
}
|
|
|
|
if startTime.After(endTime) {
|
|
response.BadRequest(c, "Invalid time range: start_time must be <= end_time")
|
|
return
|
|
}
|
|
|
|
items, err := h.opsService.ListMetricsHistory(c.Request.Context(), windowMinutes, startTime, endTime, limit)
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to list ops metrics history")
|
|
return
|
|
}
|
|
response.Success(c, gin.H{"items": items})
|
|
}
|
|
|
|
// ListErrorLogs lists recent error logs with optional filters.
|
|
// GET /api/v1/admin/ops/error-logs
|
|
//
|
|
// Query params:
|
|
// - start_time/end_time: RFC3339 timestamps (optional)
|
|
// - platform: string (optional)
|
|
// - phase: string (optional)
|
|
// - severity: string (optional)
|
|
// - q: string (optional; fuzzy match)
|
|
// - limit: int (optional; default 100; max 500)
|
|
func (h *OpsHandler) ListErrorLogs(c *gin.Context) {
|
|
var filters service.OpsErrorLogFilters
|
|
|
|
if startTimeStr := c.Query("start_time"); startTimeStr != "" {
|
|
startTime, err := time.Parse(time.RFC3339, startTimeStr)
|
|
if err != nil {
|
|
response.BadRequest(c, "Invalid start_time format (RFC3339)")
|
|
return
|
|
}
|
|
filters.StartTime = &startTime
|
|
}
|
|
if endTimeStr := c.Query("end_time"); endTimeStr != "" {
|
|
endTime, err := time.Parse(time.RFC3339, endTimeStr)
|
|
if err != nil {
|
|
response.BadRequest(c, "Invalid end_time format (RFC3339)")
|
|
return
|
|
}
|
|
filters.EndTime = &endTime
|
|
}
|
|
|
|
if filters.StartTime != nil && filters.EndTime != nil && filters.StartTime.After(*filters.EndTime) {
|
|
response.BadRequest(c, "Invalid time range: start_time must be <= end_time")
|
|
return
|
|
}
|
|
|
|
filters.Platform = c.Query("platform")
|
|
filters.Phase = c.Query("phase")
|
|
filters.Severity = c.Query("severity")
|
|
filters.Query = c.Query("q")
|
|
|
|
filters.Limit = 100
|
|
if limitStr := c.Query("limit"); limitStr != "" {
|
|
limit, err := strconv.Atoi(limitStr)
|
|
if err != nil || limit <= 0 || limit > 500 {
|
|
response.BadRequest(c, "Invalid limit (must be 1-500)")
|
|
return
|
|
}
|
|
filters.Limit = limit
|
|
}
|
|
|
|
items, total, err := h.opsService.ListErrorLogs(c.Request.Context(), filters)
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to list error logs")
|
|
return
|
|
}
|
|
|
|
response.Success(c, gin.H{
|
|
"items": items,
|
|
"total": total,
|
|
})
|
|
}
|
|
|
|
// GetDashboardOverview returns realtime ops dashboard overview.
|
|
// GET /api/v1/admin/ops/dashboard/overview
|
|
//
|
|
// Query params:
|
|
// - time_range: string (optional; default "1h") one of: 5m, 30m, 1h, 6h, 24h
|
|
func (h *OpsHandler) GetDashboardOverview(c *gin.Context) {
|
|
timeRange := c.Query("time_range")
|
|
if timeRange == "" {
|
|
timeRange = "1h"
|
|
}
|
|
|
|
switch timeRange {
|
|
case "5m", "30m", "1h", "6h", "24h":
|
|
default:
|
|
response.BadRequest(c, "Invalid time_range (supported: 5m, 30m, 1h, 6h, 24h)")
|
|
return
|
|
}
|
|
|
|
data, err := h.opsService.GetDashboardOverview(c.Request.Context(), timeRange)
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to get dashboard overview")
|
|
return
|
|
}
|
|
response.Success(c, data)
|
|
}
|
|
|
|
// GetProviderHealth returns upstream provider health comparison data.
|
|
// GET /api/v1/admin/ops/dashboard/providers
|
|
//
|
|
// Query params:
|
|
// - time_range: string (optional; default "1h") one of: 5m, 30m, 1h, 6h, 24h
|
|
func (h *OpsHandler) GetProviderHealth(c *gin.Context) {
|
|
timeRange := c.Query("time_range")
|
|
if timeRange == "" {
|
|
timeRange = "1h"
|
|
}
|
|
|
|
switch timeRange {
|
|
case "5m", "30m", "1h", "6h", "24h":
|
|
default:
|
|
response.BadRequest(c, "Invalid time_range (supported: 5m, 30m, 1h, 6h, 24h)")
|
|
return
|
|
}
|
|
|
|
providers, err := h.opsService.GetProviderHealth(c.Request.Context(), timeRange)
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to get provider health")
|
|
return
|
|
}
|
|
|
|
var totalRequests int64
|
|
var weightedSuccess float64
|
|
var bestProvider string
|
|
var worstProvider string
|
|
var bestRate float64
|
|
var worstRate float64
|
|
hasRate := false
|
|
|
|
for _, p := range providers {
|
|
if p == nil {
|
|
continue
|
|
}
|
|
totalRequests += p.RequestCount
|
|
weightedSuccess += (p.SuccessRate / 100) * float64(p.RequestCount)
|
|
|
|
if p.RequestCount <= 0 {
|
|
continue
|
|
}
|
|
if !hasRate {
|
|
bestProvider = p.Name
|
|
worstProvider = p.Name
|
|
bestRate = p.SuccessRate
|
|
worstRate = p.SuccessRate
|
|
hasRate = true
|
|
continue
|
|
}
|
|
|
|
if p.SuccessRate > bestRate {
|
|
bestProvider = p.Name
|
|
bestRate = p.SuccessRate
|
|
}
|
|
if p.SuccessRate < worstRate {
|
|
worstProvider = p.Name
|
|
worstRate = p.SuccessRate
|
|
}
|
|
}
|
|
|
|
avgSuccessRate := 0.0
|
|
if totalRequests > 0 {
|
|
avgSuccessRate = (weightedSuccess / float64(totalRequests)) * 100
|
|
avgSuccessRate = math.Round(avgSuccessRate*100) / 100
|
|
}
|
|
|
|
response.Success(c, gin.H{
|
|
"providers": providers,
|
|
"summary": gin.H{
|
|
"total_requests": totalRequests,
|
|
"avg_success_rate": avgSuccessRate,
|
|
"best_provider": bestProvider,
|
|
"worst_provider": worstProvider,
|
|
},
|
|
})
|
|
}
|
|
|
|
// GetErrorLogs returns a paginated error log list with multi-dimensional filters.
|
|
// GET /api/v1/admin/ops/errors
|
|
func (h *OpsHandler) GetErrorLogs(c *gin.Context) {
|
|
page, pageSize := response.ParsePagination(c)
|
|
|
|
filter := &service.ErrorLogFilter{
|
|
Page: page,
|
|
PageSize: pageSize,
|
|
}
|
|
|
|
if startTimeStr := c.Query("start_time"); startTimeStr != "" {
|
|
startTime, err := time.Parse(time.RFC3339, startTimeStr)
|
|
if err != nil {
|
|
response.BadRequest(c, "Invalid start_time format (RFC3339)")
|
|
return
|
|
}
|
|
filter.StartTime = &startTime
|
|
}
|
|
if endTimeStr := c.Query("end_time"); endTimeStr != "" {
|
|
endTime, err := time.Parse(time.RFC3339, endTimeStr)
|
|
if err != nil {
|
|
response.BadRequest(c, "Invalid end_time format (RFC3339)")
|
|
return
|
|
}
|
|
filter.EndTime = &endTime
|
|
}
|
|
|
|
if filter.StartTime != nil && filter.EndTime != nil && filter.StartTime.After(*filter.EndTime) {
|
|
response.BadRequest(c, "Invalid time range: start_time must be <= end_time")
|
|
return
|
|
}
|
|
|
|
if errorCodeStr := c.Query("error_code"); errorCodeStr != "" {
|
|
code, err := strconv.Atoi(errorCodeStr)
|
|
if err != nil || code < 0 {
|
|
response.BadRequest(c, "Invalid error_code")
|
|
return
|
|
}
|
|
filter.ErrorCode = &code
|
|
}
|
|
|
|
// Keep both parameter names for compatibility: provider (docs) and platform (legacy).
|
|
filter.Provider = c.Query("provider")
|
|
if filter.Provider == "" {
|
|
filter.Provider = c.Query("platform")
|
|
}
|
|
|
|
if accountIDStr := c.Query("account_id"); accountIDStr != "" {
|
|
accountID, err := strconv.ParseInt(accountIDStr, 10, 64)
|
|
if err != nil || accountID <= 0 {
|
|
response.BadRequest(c, "Invalid account_id")
|
|
return
|
|
}
|
|
filter.AccountID = &accountID
|
|
}
|
|
|
|
out, err := h.opsService.GetErrorLogs(c.Request.Context(), filter)
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to get error logs")
|
|
return
|
|
}
|
|
|
|
response.Success(c, gin.H{
|
|
"errors": out.Errors,
|
|
"total": out.Total,
|
|
"page": out.Page,
|
|
"page_size": out.PageSize,
|
|
})
|
|
}
|
|
|
|
// GetLatencyHistogram returns the latency distribution histogram.
|
|
// GET /api/v1/admin/ops/dashboard/latency-histogram
|
|
func (h *OpsHandler) GetLatencyHistogram(c *gin.Context) {
|
|
timeRange := c.Query("time_range")
|
|
if timeRange == "" {
|
|
timeRange = "1h"
|
|
}
|
|
|
|
buckets, err := h.opsService.GetLatencyHistogram(c.Request.Context(), timeRange)
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to get latency histogram")
|
|
return
|
|
}
|
|
|
|
totalRequests := int64(0)
|
|
for _, b := range buckets {
|
|
totalRequests += b.Count
|
|
}
|
|
|
|
response.Success(c, gin.H{
|
|
"buckets": buckets,
|
|
"total_requests": totalRequests,
|
|
"slow_request_threshold": 1000,
|
|
})
|
|
}
|
|
|
|
// GetErrorDistribution returns the error distribution.
|
|
// GET /api/v1/admin/ops/dashboard/errors/distribution
|
|
func (h *OpsHandler) GetErrorDistribution(c *gin.Context) {
|
|
timeRange := c.Query("time_range")
|
|
if timeRange == "" {
|
|
timeRange = "1h"
|
|
}
|
|
|
|
items, err := h.opsService.GetErrorDistribution(c.Request.Context(), timeRange)
|
|
if err != nil {
|
|
response.Error(c, http.StatusInternalServerError, "Failed to get error distribution")
|
|
return
|
|
}
|
|
|
|
response.Success(c, gin.H{
|
|
"items": items,
|
|
})
|
|
}
|