e8671fd7c2
- 新增安全路径拼接校验，确保目标文件仍在下载目录内 - 清理失败下载文件时复用安全校验，避免不安全删除路径 - 增加扩展名白名单归一化与相关单元测试 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
112 lines
3.0 KiB
Go
112 lines
3.0 KiB
Go
//go:build unit
|
|
|
|
package service
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Wei-Shaw/sub2api/internal/config"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSoraMediaStorage_StoreFromURLs(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "image/png")
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte("data"))
|
|
}))
|
|
defer server.Close()
|
|
|
|
cfg := &config.Config{
|
|
Sora: config.SoraConfig{
|
|
Storage: config.SoraStorageConfig{
|
|
Type: "local",
|
|
LocalPath: tmpDir,
|
|
MaxConcurrentDownloads: 1,
|
|
},
|
|
},
|
|
}
|
|
|
|
storage := NewSoraMediaStorage(cfg)
|
|
urls, err := storage.StoreFromURLs(context.Background(), "image", []string{server.URL + "/img.png"})
|
|
require.NoError(t, err)
|
|
require.Len(t, urls, 1)
|
|
require.True(t, strings.HasPrefix(urls[0], "/image/"))
|
|
require.True(t, strings.HasSuffix(urls[0], ".png"))
|
|
|
|
localPath := filepath.Join(tmpDir, filepath.FromSlash(strings.TrimPrefix(urls[0], "/")))
|
|
require.FileExists(t, localPath)
|
|
}
|
|
|
|
func TestSoraMediaStorage_FallbackToUpstream(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}))
|
|
defer server.Close()
|
|
|
|
cfg := &config.Config{
|
|
Sora: config.SoraConfig{
|
|
Storage: config.SoraStorageConfig{
|
|
Type: "local",
|
|
LocalPath: tmpDir,
|
|
FallbackToUpstream: true,
|
|
},
|
|
},
|
|
}
|
|
|
|
storage := NewSoraMediaStorage(cfg)
|
|
url := server.URL + "/broken.png"
|
|
urls, err := storage.StoreFromURLs(context.Background(), "image", []string{url})
|
|
require.NoError(t, err)
|
|
require.Equal(t, []string{url}, urls)
|
|
}
|
|
|
|
func TestSoraMediaStorage_MaxDownloadBytes(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "image/png")
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write([]byte("too-large"))
|
|
}))
|
|
defer server.Close()
|
|
|
|
cfg := &config.Config{
|
|
Sora: config.SoraConfig{
|
|
Storage: config.SoraStorageConfig{
|
|
Type: "local",
|
|
LocalPath: tmpDir,
|
|
MaxDownloadBytes: 1,
|
|
},
|
|
},
|
|
}
|
|
|
|
storage := NewSoraMediaStorage(cfg)
|
|
_, err := storage.StoreFromURLs(context.Background(), "image", []string{server.URL + "/img.png"})
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestJoinPathWithinDir(t *testing.T) {
|
|
baseDir := t.TempDir()
|
|
|
|
path1, err := joinPathWithinDir(baseDir, "ok.png")
|
|
require.NoError(t, err)
|
|
require.Equal(t, filepath.Join(baseDir, "ok.png"), path1)
|
|
|
|
_, err = joinPathWithinDir(baseDir, "../escape.png")
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestNormalizeSoraFileExt(t *testing.T) {
|
|
require.Equal(t, ".png", normalizeSoraFileExt(".PNG"))
|
|
require.Equal(t, ".mp4", normalizeSoraFileExt(".mp4"))
|
|
require.Equal(t, "", normalizeSoraFileExt("../../etc/passwd"))
|
|
require.Equal(t, "", normalizeSoraFileExt(".php"))
|
|
}
|