- Drop SetAffiliateService setters and ProvideAuthService / ProvidePaymentService / ProvideUserHandler wrappers in favor of direct Wire constructor injection. AffiliateService has no back-edge to Auth/Payment/User, so the indirection was never required. - Change RegisterWithVerification's variadic affiliateCode to a fixed parameter; adjust all call sites. - Validate aff_code length and charset in BindInviterByCode before any DB lookup, eliminating timing-side-channel and useless DB roundtrips on malformed input. - Make affiliate cache invalidation synchronous; surface Redis errors via the project logger instead of swallowing them in a detached goroutine. - Add an integration test guarding cross-layer tx propagation in AccrueQuota and a unit test pinning the aff_code format rules.
185 lines
6.5 KiB
Go
185 lines
6.5 KiB
Go
//go:build integration
|
|
|
|
package repository
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
dbent "github.com/Wei-Shaw/sub2api/ent"
|
|
"github.com/Wei-Shaw/sub2api/internal/service"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func querySingleFloat(t *testing.T, ctx context.Context, client *dbent.Client, query string, args ...any) float64 {
|
|
t.Helper()
|
|
rows, err := client.QueryContext(ctx, query, args...)
|
|
require.NoError(t, err)
|
|
defer func() { _ = rows.Close() }()
|
|
|
|
require.True(t, rows.Next(), "expected one row")
|
|
var value float64
|
|
require.NoError(t, rows.Scan(&value))
|
|
require.NoError(t, rows.Err())
|
|
return value
|
|
}
|
|
|
|
func querySingleInt(t *testing.T, ctx context.Context, client *dbent.Client, query string, args ...any) int {
|
|
t.Helper()
|
|
rows, err := client.QueryContext(ctx, query, args...)
|
|
require.NoError(t, err)
|
|
defer func() { _ = rows.Close() }()
|
|
|
|
require.True(t, rows.Next(), "expected one row")
|
|
var value int
|
|
require.NoError(t, rows.Scan(&value))
|
|
require.NoError(t, rows.Err())
|
|
return value
|
|
}
|
|
|
|
func TestAffiliateRepository_TransferQuotaToBalance_UsesClaimedQuotaBeforeClear(t *testing.T) {
|
|
ctx := context.Background()
|
|
tx := testEntTx(t)
|
|
txCtx := dbent.NewTxContext(ctx, tx)
|
|
client := tx.Client()
|
|
|
|
repo := NewAffiliateRepository(client, integrationDB)
|
|
|
|
u := mustCreateUser(t, client, &service.User{
|
|
Email: fmt.Sprintf("affiliate-transfer-%d@example.com", time.Now().UnixNano()),
|
|
PasswordHash: "hash",
|
|
Role: service.RoleUser,
|
|
Status: service.StatusActive,
|
|
Balance: 5.5,
|
|
Concurrency: 5,
|
|
})
|
|
|
|
affCode := fmt.Sprintf("AFF%09d", time.Now().UnixNano()%1_000_000_000)
|
|
_, err := client.ExecContext(txCtx, `
|
|
INSERT INTO user_affiliates (user_id, aff_code, aff_quota, aff_history_quota, created_at, updated_at)
|
|
VALUES ($1, $2, $3, $3, NOW(), NOW())`, u.ID, affCode, 12.34)
|
|
require.NoError(t, err)
|
|
|
|
transferred, balance, err := repo.TransferQuotaToBalance(txCtx, u.ID)
|
|
require.NoError(t, err)
|
|
require.InDelta(t, 12.34, transferred, 1e-9)
|
|
require.InDelta(t, 17.84, balance, 1e-9)
|
|
|
|
affQuota := querySingleFloat(t, txCtx, client,
|
|
"SELECT aff_quota::double precision FROM user_affiliates WHERE user_id = $1", u.ID)
|
|
require.InDelta(t, 0.0, affQuota, 1e-9)
|
|
|
|
persistedBalance := querySingleFloat(t, txCtx, client,
|
|
"SELECT balance::double precision FROM users WHERE id = $1", u.ID)
|
|
require.InDelta(t, 17.84, persistedBalance, 1e-9)
|
|
|
|
ledgerCount := querySingleInt(t, txCtx, client,
|
|
"SELECT COUNT(*) FROM user_affiliate_ledger WHERE user_id = $1 AND action = 'transfer'", u.ID)
|
|
require.Equal(t, 1, ledgerCount)
|
|
}
|
|
|
|
// TestAffiliateRepository_AccrueQuota_ReusesOuterTransaction guards the
|
|
// cross-layer tx propagation invariant: when AccrueQuota is called with a ctx
|
|
// that already carries a transaction (via dbent.NewTxContext), repo.withTx
|
|
// must reuse that tx rather than opening a nested one. If this invariant
|
|
// breaks, AccrueQuota would commit independently and survive a rollback of
|
|
// the outer tx, which would violate payment_fulfillment's all-or-nothing
|
|
// semantics.
|
|
func TestAffiliateRepository_AccrueQuota_ReusesOuterTransaction(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
outerTx, err := integrationEntClient.Tx(ctx)
|
|
require.NoError(t, err, "begin outer tx")
|
|
// Defensive cleanup: if any require.* below fires before the explicit
|
|
// Rollback, this prevents the tx from leaking until container teardown.
|
|
// Rollback is idempotent at the driver level (extra rollback returns an
|
|
// error we ignore).
|
|
t.Cleanup(func() { _ = outerTx.Rollback() })
|
|
client := outerTx.Client()
|
|
txCtx := dbent.NewTxContext(ctx, outerTx)
|
|
|
|
inviter := mustCreateUser(t, client, &service.User{
|
|
Email: fmt.Sprintf("affiliate-inviter-%d@example.com", time.Now().UnixNano()),
|
|
PasswordHash: "hash",
|
|
Role: service.RoleUser,
|
|
Status: service.StatusActive,
|
|
Concurrency: 5,
|
|
})
|
|
invitee := mustCreateUser(t, client, &service.User{
|
|
Email: fmt.Sprintf("affiliate-invitee-%d@example.com", time.Now().UnixNano()+1),
|
|
PasswordHash: "hash",
|
|
Role: service.RoleUser,
|
|
Status: service.StatusActive,
|
|
Concurrency: 5,
|
|
})
|
|
|
|
repo := NewAffiliateRepository(client, integrationDB)
|
|
_, err = repo.EnsureUserAffiliate(txCtx, inviter.ID)
|
|
require.NoError(t, err)
|
|
_, err = repo.EnsureUserAffiliate(txCtx, invitee.ID)
|
|
require.NoError(t, err)
|
|
|
|
bound, err := repo.BindInviter(txCtx, invitee.ID, inviter.ID)
|
|
require.NoError(t, err)
|
|
require.True(t, bound, "invitee must bind to inviter")
|
|
|
|
applied, err := repo.AccrueQuota(txCtx, inviter.ID, invitee.ID, 3.5)
|
|
require.NoError(t, err)
|
|
require.True(t, applied, "AccrueQuota must report applied=true")
|
|
|
|
// Visible inside the outer tx.
|
|
innerQuota := querySingleFloat(t, txCtx, client,
|
|
"SELECT aff_quota::double precision FROM user_affiliates WHERE user_id = $1", inviter.ID)
|
|
require.InDelta(t, 3.5, innerQuota, 1e-9)
|
|
|
|
// Roll back the outer tx; if AccrueQuota had opened its own inner tx and
|
|
// committed it, the rows would still be visible to the global client.
|
|
require.NoError(t, outerTx.Rollback())
|
|
|
|
rows, err := integrationEntClient.QueryContext(ctx,
|
|
"SELECT COUNT(*) FROM user_affiliates WHERE user_id IN ($1, $2)",
|
|
inviter.ID, invitee.ID)
|
|
require.NoError(t, err)
|
|
defer func() { _ = rows.Close() }()
|
|
require.True(t, rows.Next())
|
|
var postRollbackCount int
|
|
require.NoError(t, rows.Scan(&postRollbackCount))
|
|
require.Equal(t, 0, postRollbackCount,
|
|
"AccrueQuota must propagate the outer tx — found persisted rows after rollback")
|
|
}
|
|
|
|
func TestAffiliateRepository_TransferQuotaToBalance_EmptyQuota(t *testing.T) {
|
|
ctx := context.Background()
|
|
tx := testEntTx(t)
|
|
txCtx := dbent.NewTxContext(ctx, tx)
|
|
client := tx.Client()
|
|
|
|
repo := NewAffiliateRepository(client, integrationDB)
|
|
|
|
u := mustCreateUser(t, client, &service.User{
|
|
Email: fmt.Sprintf("affiliate-empty-%d@example.com", time.Now().UnixNano()),
|
|
PasswordHash: "hash",
|
|
Role: service.RoleUser,
|
|
Status: service.StatusActive,
|
|
Balance: 3.21,
|
|
Concurrency: 5,
|
|
})
|
|
|
|
affCode := fmt.Sprintf("AFF%09d", time.Now().UnixNano()%1_000_000_000)
|
|
_, err := client.ExecContext(txCtx, `
|
|
INSERT INTO user_affiliates (user_id, aff_code, aff_quota, aff_history_quota, created_at, updated_at)
|
|
VALUES ($1, $2, 0, 0, NOW(), NOW())`, u.ID, affCode)
|
|
require.NoError(t, err)
|
|
|
|
transferred, balance, err := repo.TransferQuotaToBalance(txCtx, u.ID)
|
|
require.ErrorIs(t, err, service.ErrAffiliateQuotaEmpty)
|
|
require.InDelta(t, 0.0, transferred, 1e-9)
|
|
require.InDelta(t, 0.0, balance, 1e-9)
|
|
|
|
persistedBalance := querySingleFloat(t, txCtx, client,
|
|
"SELECT balance::double precision FROM users WHERE id = $1", u.ID)
|
|
require.InDelta(t, 3.21, persistedBalance, 1e-9)
|
|
}
|