a9880ee7b9
Security (HIGH): - Normalize all Redis cache keys to lowercase (verifyCode, passwordReset) - Fix verify code TTL renewal on failed attempts: use remaining TTL via ExpiresAt field instead of resetting to full 15-minute window - Add 3 missing fields to diffSettings audit log (promo_code, invitation_code, custom_endpoints) Code quality (MEDIUM): - Extract filterVerifiedEmails shared helper (balance_notify_service.go) - Add Pricing array non-empty validation for channel pricing rules - Add platform token semantics comment in gateway_service.go - Complete validatePlanPatch test coverage (+10 test cases) - Replace string types with QuotaThresholdType/QuotaResetMode across frontend - Remove duplicate getPlatformTextColor/getRateBadgeClass in ChannelsView - Return EMAIL_NOT_FOUND error on RemoveNotifyEmail miss UI improvements: - Reorder cost tooltip: user billing above separator, account billing below - Add NaN guard to accountBilled function - Move timezone selector inline into reset-mode row (no longer standalone)
194 lines
5.7 KiB
Go
194 lines
5.7 KiB
Go
//go:build unit
|
|
|
|
package service
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestValidatePlanRequired_AllValid(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 1, 9.99, 30, "days", nil)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanRequired_EmptyName(t *testing.T) {
|
|
err := validatePlanRequired("", 1, 9.99, 30, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "plan name")
|
|
}
|
|
|
|
func TestValidatePlanRequired_WhitespaceName(t *testing.T) {
|
|
err := validatePlanRequired(" ", 1, 9.99, 30, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "plan name")
|
|
}
|
|
|
|
func TestValidatePlanRequired_ZeroGroupID(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 0, 9.99, 30, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "group")
|
|
}
|
|
|
|
func TestValidatePlanRequired_NegativeGroupID(t *testing.T) {
|
|
err := validatePlanRequired("Pro", -1, 9.99, 30, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "group")
|
|
}
|
|
|
|
func TestValidatePlanRequired_ZeroPrice(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 1, 0, 30, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "price")
|
|
}
|
|
|
|
func TestValidatePlanRequired_NegativePrice(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 1, -5, 30, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "price")
|
|
}
|
|
|
|
func TestValidatePlanRequired_ZeroValidityDays(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 1, 9.99, 0, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "validity days")
|
|
}
|
|
|
|
func TestValidatePlanRequired_NegativeValidityDays(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 1, 9.99, -7, "days", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "validity days")
|
|
}
|
|
|
|
func TestValidatePlanRequired_EmptyValidityUnit(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 1, 9.99, 30, "", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "validity unit")
|
|
}
|
|
|
|
func TestValidatePlanRequired_WhitespaceValidityUnit(t *testing.T) {
|
|
err := validatePlanRequired("Pro", 1, 9.99, 30, " ", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "validity unit")
|
|
}
|
|
|
|
func TestValidatePlanRequired_NameValidatedFirst(t *testing.T) {
|
|
err := validatePlanRequired("", 0, 0, 0, "", nil)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "plan name")
|
|
}
|
|
|
|
func TestValidatePlanRequired_TrimmedValidName(t *testing.T) {
|
|
err := validatePlanRequired(" Pro ", 1, 9.99, 30, "days", nil)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanRequired_NegativeOriginalPrice(t *testing.T) {
|
|
neg := -10.0
|
|
err := validatePlanRequired("Pro", 1, 9.99, 30, "days", &neg)
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "original price")
|
|
}
|
|
|
|
func TestValidatePlanRequired_ZeroOriginalPrice(t *testing.T) {
|
|
zero := 0.0
|
|
err := validatePlanRequired("Pro", 1, 9.99, 30, "days", &zero)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanRequired_ValidOriginalPrice(t *testing.T) {
|
|
op := 19.99
|
|
err := validatePlanRequired("Pro", 1, 9.99, 30, "days", &op)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
// --- validatePlanPatch tests ---
|
|
|
|
func TestValidatePlanPatch_NegativeOriginalPrice(t *testing.T) {
|
|
neg := -5.0
|
|
err := validatePlanPatch(UpdatePlanRequest{OriginalPrice: &neg})
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "original price")
|
|
}
|
|
|
|
func TestValidatePlanPatch_ZeroOriginalPrice(t *testing.T) {
|
|
zero := 0.0
|
|
err := validatePlanPatch(UpdatePlanRequest{OriginalPrice: &zero})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanPatch_ValidOriginalPrice(t *testing.T) {
|
|
op := 29.99
|
|
err := validatePlanPatch(UpdatePlanRequest{OriginalPrice: &op})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanPatch_NilOriginalPrice(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{OriginalPrice: nil})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
// --- validatePlanPatch: other fields ---
|
|
|
|
func ptrStr(s string) *string { return &s }
|
|
func ptrInt(i int) *int { return &i }
|
|
func ptrInt64(i int64) *int64 { return &i }
|
|
func ptrFloat(f float64) *float64 { return &f }
|
|
|
|
func TestValidatePlanPatch_EmptyName(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{Name: ptrStr("")})
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "plan name")
|
|
}
|
|
|
|
func TestValidatePlanPatch_ValidName(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{Name: ptrStr("Basic")})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanPatch_ZeroGroupID(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{GroupID: ptrInt64(0)})
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "group")
|
|
}
|
|
|
|
func TestValidatePlanPatch_NegativePrice(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{Price: ptrFloat(-1)})
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "price")
|
|
}
|
|
|
|
func TestValidatePlanPatch_ZeroPrice(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{Price: ptrFloat(0)})
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "price")
|
|
}
|
|
|
|
func TestValidatePlanPatch_ValidPrice(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{Price: ptrFloat(9.99)})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanPatch_ZeroValidityDays(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{ValidityDays: ptrInt(0)})
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "validity days")
|
|
}
|
|
|
|
func TestValidatePlanPatch_EmptyValidityUnit(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{ValidityUnit: ptrStr("")})
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "validity unit")
|
|
}
|
|
|
|
func TestValidatePlanPatch_ValidValidityUnit(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{ValidityUnit: ptrStr("days")})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestValidatePlanPatch_AllNil(t *testing.T) {
|
|
err := validatePlanPatch(UpdatePlanRequest{})
|
|
require.NoError(t, err)
|
|
}
|