基于 backend-code-audit 审计报告,修复剩余 P0/P1/P2 共 34 项问题: P0 生产 Bug: - 修复 time.Since(time.Now()) 计时逻辑错误 (P0-03) - generateRandomID 改用 crypto/rand 替代固定索引 (P0-04) - IncrementQuotaUsed 重写为 Ent 原子操作消除 TOCTOU 竞态 (P0-05) 安全加固: - gateway/openai handler 错误响应替换为泛化消息,防止内部信息泄露 (P1-14) - usage_log_repo dateFormat 参数改用白名单映射,防止 SQL 注入 (P1-16) - 默认配置安全加固:sslmode=prefer、response_headers=true、mode=release (P1-18/19, P2-15) 性能优化: - gateway handler 循环内 defer 替换为显式 releaseWait 闭包 (P1-02) - group_repo/promo_code_repo Count 前 Clone 查询避免状态污染 (P1-03) - usage_log_repo 四个查询添加 LIMIT 10000 防止 OOM (P1-07) - GetBatchUsageStats 添加时间范围参数,默认最近 30 天 (P1-10) - ip.go CIDR 预编译为包级变量 (P1-11) - BatchUpdateCredentials 重构为先验证后更新 (P1-13) 缓存一致性: - billing_cache 添加 jitteredTTL 防止缓存雪崩 (P2-10) - DeductUserBalance/UpdateSubscriptionUsage 错误传播修复 (P2-12) - UserService.UpdateBalance 成功后异步失效 billingCache (P2-13) 代码质量: - search 截断改为按 rune 处理,支持多字节字符 (P2-01) - TLS Handshake 改为 HandshakeContext 支持 context 取消 (P2-07) - CORS 预检添加 Access-Control-Max-Age: 86400 (P2-16) 测试覆盖: - 新增 user_service_test.go(UpdateBalance 缓存失效 6 个用例) - 新增 batch_update_credentials_test.go(fail-fast + 类型验证 7 个用例) - 新增 response_transformer_test.go、ip_test.go、usage_log_repo_unit_test.go、search_truncate_test.go - 集成测试:IncrementQuotaUsed 并发测试、billing_cache 错误传播测试 - config_test.go 补充 server.mode/sslmode 默认值断言 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
274 lines
6.9 KiB
Go
274 lines
6.9 KiB
Go
package repository
|
|
|
|
import (
|
|
"context"
|
|
|
|
dbent "github.com/Wei-Shaw/sub2api/ent"
|
|
"github.com/Wei-Shaw/sub2api/ent/promocode"
|
|
"github.com/Wei-Shaw/sub2api/ent/promocodeusage"
|
|
"github.com/Wei-Shaw/sub2api/internal/pkg/pagination"
|
|
"github.com/Wei-Shaw/sub2api/internal/service"
|
|
)
|
|
|
|
type promoCodeRepository struct {
|
|
client *dbent.Client
|
|
}
|
|
|
|
func NewPromoCodeRepository(client *dbent.Client) service.PromoCodeRepository {
|
|
return &promoCodeRepository{client: client}
|
|
}
|
|
|
|
func (r *promoCodeRepository) Create(ctx context.Context, code *service.PromoCode) error {
|
|
client := clientFromContext(ctx, r.client)
|
|
builder := client.PromoCode.Create().
|
|
SetCode(code.Code).
|
|
SetBonusAmount(code.BonusAmount).
|
|
SetMaxUses(code.MaxUses).
|
|
SetUsedCount(code.UsedCount).
|
|
SetStatus(code.Status).
|
|
SetNotes(code.Notes)
|
|
|
|
if code.ExpiresAt != nil {
|
|
builder.SetExpiresAt(*code.ExpiresAt)
|
|
}
|
|
|
|
created, err := builder.Save(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
code.ID = created.ID
|
|
code.CreatedAt = created.CreatedAt
|
|
code.UpdatedAt = created.UpdatedAt
|
|
return nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) GetByID(ctx context.Context, id int64) (*service.PromoCode, error) {
|
|
m, err := r.client.PromoCode.Query().
|
|
Where(promocode.IDEQ(id)).
|
|
Only(ctx)
|
|
if err != nil {
|
|
if dbent.IsNotFound(err) {
|
|
return nil, service.ErrPromoCodeNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return promoCodeEntityToService(m), nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) GetByCode(ctx context.Context, code string) (*service.PromoCode, error) {
|
|
m, err := r.client.PromoCode.Query().
|
|
Where(promocode.CodeEqualFold(code)).
|
|
Only(ctx)
|
|
if err != nil {
|
|
if dbent.IsNotFound(err) {
|
|
return nil, service.ErrPromoCodeNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return promoCodeEntityToService(m), nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) GetByCodeForUpdate(ctx context.Context, code string) (*service.PromoCode, error) {
|
|
client := clientFromContext(ctx, r.client)
|
|
m, err := client.PromoCode.Query().
|
|
Where(promocode.CodeEqualFold(code)).
|
|
ForUpdate().
|
|
Only(ctx)
|
|
if err != nil {
|
|
if dbent.IsNotFound(err) {
|
|
return nil, service.ErrPromoCodeNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return promoCodeEntityToService(m), nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) Update(ctx context.Context, code *service.PromoCode) error {
|
|
client := clientFromContext(ctx, r.client)
|
|
builder := client.PromoCode.UpdateOneID(code.ID).
|
|
SetCode(code.Code).
|
|
SetBonusAmount(code.BonusAmount).
|
|
SetMaxUses(code.MaxUses).
|
|
SetUsedCount(code.UsedCount).
|
|
SetStatus(code.Status).
|
|
SetNotes(code.Notes)
|
|
|
|
if code.ExpiresAt != nil {
|
|
builder.SetExpiresAt(*code.ExpiresAt)
|
|
} else {
|
|
builder.ClearExpiresAt()
|
|
}
|
|
|
|
updated, err := builder.Save(ctx)
|
|
if err != nil {
|
|
if dbent.IsNotFound(err) {
|
|
return service.ErrPromoCodeNotFound
|
|
}
|
|
return err
|
|
}
|
|
|
|
code.UpdatedAt = updated.UpdatedAt
|
|
return nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) Delete(ctx context.Context, id int64) error {
|
|
client := clientFromContext(ctx, r.client)
|
|
_, err := client.PromoCode.Delete().Where(promocode.IDEQ(id)).Exec(ctx)
|
|
return err
|
|
}
|
|
|
|
func (r *promoCodeRepository) List(ctx context.Context, params pagination.PaginationParams) ([]service.PromoCode, *pagination.PaginationResult, error) {
|
|
return r.ListWithFilters(ctx, params, "", "")
|
|
}
|
|
|
|
func (r *promoCodeRepository) ListWithFilters(ctx context.Context, params pagination.PaginationParams, status, search string) ([]service.PromoCode, *pagination.PaginationResult, error) {
|
|
q := r.client.PromoCode.Query()
|
|
|
|
if status != "" {
|
|
q = q.Where(promocode.StatusEQ(status))
|
|
}
|
|
if search != "" {
|
|
q = q.Where(promocode.CodeContainsFold(search))
|
|
}
|
|
|
|
total, err := q.Clone().Count(ctx)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
codes, err := q.
|
|
Offset(params.Offset()).
|
|
Limit(params.Limit()).
|
|
Order(dbent.Desc(promocode.FieldID)).
|
|
All(ctx)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
outCodes := promoCodeEntitiesToService(codes)
|
|
|
|
return outCodes, paginationResultFromTotal(int64(total), params), nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) CreateUsage(ctx context.Context, usage *service.PromoCodeUsage) error {
|
|
client := clientFromContext(ctx, r.client)
|
|
created, err := client.PromoCodeUsage.Create().
|
|
SetPromoCodeID(usage.PromoCodeID).
|
|
SetUserID(usage.UserID).
|
|
SetBonusAmount(usage.BonusAmount).
|
|
SetUsedAt(usage.UsedAt).
|
|
Save(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
usage.ID = created.ID
|
|
return nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) GetUsageByPromoCodeAndUser(ctx context.Context, promoCodeID, userID int64) (*service.PromoCodeUsage, error) {
|
|
m, err := r.client.PromoCodeUsage.Query().
|
|
Where(
|
|
promocodeusage.PromoCodeIDEQ(promoCodeID),
|
|
promocodeusage.UserIDEQ(userID),
|
|
).
|
|
Only(ctx)
|
|
if err != nil {
|
|
if dbent.IsNotFound(err) {
|
|
return nil, nil
|
|
}
|
|
return nil, err
|
|
}
|
|
return promoCodeUsageEntityToService(m), nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) ListUsagesByPromoCode(ctx context.Context, promoCodeID int64, params pagination.PaginationParams) ([]service.PromoCodeUsage, *pagination.PaginationResult, error) {
|
|
q := r.client.PromoCodeUsage.Query().
|
|
Where(promocodeusage.PromoCodeIDEQ(promoCodeID))
|
|
|
|
total, err := q.Clone().Count(ctx)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
usages, err := q.
|
|
WithUser().
|
|
Offset(params.Offset()).
|
|
Limit(params.Limit()).
|
|
Order(dbent.Desc(promocodeusage.FieldID)).
|
|
All(ctx)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
outUsages := promoCodeUsageEntitiesToService(usages)
|
|
|
|
return outUsages, paginationResultFromTotal(int64(total), params), nil
|
|
}
|
|
|
|
func (r *promoCodeRepository) IncrementUsedCount(ctx context.Context, id int64) error {
|
|
client := clientFromContext(ctx, r.client)
|
|
_, err := client.PromoCode.UpdateOneID(id).
|
|
AddUsedCount(1).
|
|
Save(ctx)
|
|
return err
|
|
}
|
|
|
|
// Entity to Service conversions
|
|
|
|
func promoCodeEntityToService(m *dbent.PromoCode) *service.PromoCode {
|
|
if m == nil {
|
|
return nil
|
|
}
|
|
return &service.PromoCode{
|
|
ID: m.ID,
|
|
Code: m.Code,
|
|
BonusAmount: m.BonusAmount,
|
|
MaxUses: m.MaxUses,
|
|
UsedCount: m.UsedCount,
|
|
Status: m.Status,
|
|
ExpiresAt: m.ExpiresAt,
|
|
Notes: derefString(m.Notes),
|
|
CreatedAt: m.CreatedAt,
|
|
UpdatedAt: m.UpdatedAt,
|
|
}
|
|
}
|
|
|
|
func promoCodeEntitiesToService(models []*dbent.PromoCode) []service.PromoCode {
|
|
out := make([]service.PromoCode, 0, len(models))
|
|
for i := range models {
|
|
if s := promoCodeEntityToService(models[i]); s != nil {
|
|
out = append(out, *s)
|
|
}
|
|
}
|
|
return out
|
|
}
|
|
|
|
func promoCodeUsageEntityToService(m *dbent.PromoCodeUsage) *service.PromoCodeUsage {
|
|
if m == nil {
|
|
return nil
|
|
}
|
|
out := &service.PromoCodeUsage{
|
|
ID: m.ID,
|
|
PromoCodeID: m.PromoCodeID,
|
|
UserID: m.UserID,
|
|
BonusAmount: m.BonusAmount,
|
|
UsedAt: m.UsedAt,
|
|
}
|
|
if m.Edges.User != nil {
|
|
out.User = userEntityToService(m.Edges.User)
|
|
}
|
|
return out
|
|
}
|
|
|
|
func promoCodeUsageEntitiesToService(models []*dbent.PromoCodeUsage) []service.PromoCodeUsage {
|
|
out := make([]service.PromoCodeUsage, 0, len(models))
|
|
for i := range models {
|
|
if s := promoCodeUsageEntityToService(models[i]); s != nil {
|
|
out = append(out, *s)
|
|
}
|
|
}
|
|
return out
|
|
}
|