根据 Codex 代码审查报告,修复所有 P0 和 P1 优先级问题。 ## P0 紧急修复 ### 1. 修复集成测试编译错误 - 更新 group_repo_integration_test.go 中所有 ListWithFilters 调用 - 添加缺失的 search 参数(传入空字符串) - 修复 4 处旧签名调用,避免 CI 编译失败 ### 2. 添加统一的 search 参数输入验证 为所有 admin handler 添加一致的输入验证逻辑: - group_handler.go: 添加 TrimSpace + 长度限制 - proxy_handler.go: 添加 TrimSpace + 长度限制 - redeem_handler.go: 添加 TrimSpace + 长度限制 - user_handler.go: 添加 TrimSpace + 长度限制 验证规则: - TrimSpace() 去除首尾空格 - 最大长度 100 字符(防止 DoS 攻击) - 超长输入自动截断 ## P1 改进 ### 3. 补充 search 功能的单元测试 新增 admin_service_group_test.go 中的测试: - TestAdminService_ListGroups_WithSearch - search 参数正常传递到 repository 层 - search 为空字符串时的行为 - search 与其他过滤条件组合使用 新增 admin_service_search_test.go 文件: - 为其他 admin API 添加 search 测试覆盖 - 统一的测试模式和断言 ### 4. 补充 search 功能的集成测试 新增 group_repo_integration_test.go 测试场景: - TestListWithFilters_Search - 搜索 name 字段匹配 - 搜索 description 字段匹配 - 搜索不存在内容(返回空) - 大小写不敏感测试 - 特殊字符转义测试(%、_) - 与其他过滤条件组合 ## 测试结果 - ✅ 编译检查通过 - ✅ 单元测试全部通过 (3/3) - ✅ 集成测试编译通过 - ✅ 所有 service 测试通过 ## 影响范围 修改文件: 8 个 代码变更: +234 行 / -8 行 ## 相关 Issue 解决代码审查中的安全性和稳定性问题: - 防止 DoS 攻击(超长搜索字符串) - 修复测试编译错误(CI 阻塞问题) - 提升测试覆盖率
245 lines
6.5 KiB
Go
245 lines
6.5 KiB
Go
package admin
|
||
|
||
import (
|
||
"bytes"
|
||
"encoding/csv"
|
||
"fmt"
|
||
"strconv"
|
||
"strings"
|
||
|
||
"github.com/Wei-Shaw/sub2api/internal/handler/dto"
|
||
"github.com/Wei-Shaw/sub2api/internal/pkg/response"
|
||
"github.com/Wei-Shaw/sub2api/internal/service"
|
||
|
||
"github.com/gin-gonic/gin"
|
||
)
|
||
|
||
// RedeemHandler handles admin redeem code management
|
||
type RedeemHandler struct {
|
||
adminService service.AdminService
|
||
}
|
||
|
||
// NewRedeemHandler creates a new admin redeem handler
|
||
func NewRedeemHandler(adminService service.AdminService) *RedeemHandler {
|
||
return &RedeemHandler{
|
||
adminService: adminService,
|
||
}
|
||
}
|
||
|
||
// GenerateRedeemCodesRequest represents generate redeem codes request
|
||
type GenerateRedeemCodesRequest struct {
|
||
Count int `json:"count" binding:"required,min=1,max=100"`
|
||
Type string `json:"type" binding:"required,oneof=balance concurrency subscription"`
|
||
Value float64 `json:"value" binding:"min=0"`
|
||
GroupID *int64 `json:"group_id"` // 订阅类型必填
|
||
ValidityDays int `json:"validity_days" binding:"omitempty,max=36500"` // 订阅类型使用,默认30天,最大100年
|
||
}
|
||
|
||
// List handles listing all redeem codes with pagination
|
||
// GET /api/v1/admin/redeem-codes
|
||
func (h *RedeemHandler) List(c *gin.Context) {
|
||
page, pageSize := response.ParsePagination(c)
|
||
codeType := c.Query("type")
|
||
status := c.Query("status")
|
||
search := c.Query("search")
|
||
// 标准化和验证 search 参数
|
||
search = strings.TrimSpace(search)
|
||
if len(search) > 100 {
|
||
search = search[:100]
|
||
}
|
||
|
||
codes, total, err := h.adminService.ListRedeemCodes(c.Request.Context(), page, pageSize, codeType, status, search)
|
||
if err != nil {
|
||
response.ErrorFrom(c, err)
|
||
return
|
||
}
|
||
|
||
out := make([]dto.RedeemCode, 0, len(codes))
|
||
for i := range codes {
|
||
out = append(out, *dto.RedeemCodeFromService(&codes[i]))
|
||
}
|
||
response.Paginated(c, out, total, page, pageSize)
|
||
}
|
||
|
||
// GetByID handles getting a redeem code by ID
|
||
// GET /api/v1/admin/redeem-codes/:id
|
||
func (h *RedeemHandler) GetByID(c *gin.Context) {
|
||
codeID, err := strconv.ParseInt(c.Param("id"), 10, 64)
|
||
if err != nil {
|
||
response.BadRequest(c, "Invalid redeem code ID")
|
||
return
|
||
}
|
||
|
||
code, err := h.adminService.GetRedeemCode(c.Request.Context(), codeID)
|
||
if err != nil {
|
||
response.ErrorFrom(c, err)
|
||
return
|
||
}
|
||
|
||
response.Success(c, dto.RedeemCodeFromService(code))
|
||
}
|
||
|
||
// Generate handles generating new redeem codes
|
||
// POST /api/v1/admin/redeem-codes/generate
|
||
func (h *RedeemHandler) Generate(c *gin.Context) {
|
||
var req GenerateRedeemCodesRequest
|
||
if err := c.ShouldBindJSON(&req); err != nil {
|
||
response.BadRequest(c, "Invalid request: "+err.Error())
|
||
return
|
||
}
|
||
|
||
codes, err := h.adminService.GenerateRedeemCodes(c.Request.Context(), &service.GenerateRedeemCodesInput{
|
||
Count: req.Count,
|
||
Type: req.Type,
|
||
Value: req.Value,
|
||
GroupID: req.GroupID,
|
||
ValidityDays: req.ValidityDays,
|
||
})
|
||
if err != nil {
|
||
response.ErrorFrom(c, err)
|
||
return
|
||
}
|
||
|
||
out := make([]dto.RedeemCode, 0, len(codes))
|
||
for i := range codes {
|
||
out = append(out, *dto.RedeemCodeFromService(&codes[i]))
|
||
}
|
||
response.Success(c, out)
|
||
}
|
||
|
||
// Delete handles deleting a redeem code
|
||
// DELETE /api/v1/admin/redeem-codes/:id
|
||
func (h *RedeemHandler) Delete(c *gin.Context) {
|
||
codeID, err := strconv.ParseInt(c.Param("id"), 10, 64)
|
||
if err != nil {
|
||
response.BadRequest(c, "Invalid redeem code ID")
|
||
return
|
||
}
|
||
|
||
err = h.adminService.DeleteRedeemCode(c.Request.Context(), codeID)
|
||
if err != nil {
|
||
response.ErrorFrom(c, err)
|
||
return
|
||
}
|
||
|
||
response.Success(c, gin.H{"message": "Redeem code deleted successfully"})
|
||
}
|
||
|
||
// BatchDelete handles batch deleting redeem codes
|
||
// POST /api/v1/admin/redeem-codes/batch-delete
|
||
func (h *RedeemHandler) BatchDelete(c *gin.Context) {
|
||
var req struct {
|
||
IDs []int64 `json:"ids" binding:"required,min=1"`
|
||
}
|
||
if err := c.ShouldBindJSON(&req); err != nil {
|
||
response.BadRequest(c, "Invalid request: "+err.Error())
|
||
return
|
||
}
|
||
|
||
deleted, err := h.adminService.BatchDeleteRedeemCodes(c.Request.Context(), req.IDs)
|
||
if err != nil {
|
||
response.ErrorFrom(c, err)
|
||
return
|
||
}
|
||
|
||
response.Success(c, gin.H{
|
||
"deleted": deleted,
|
||
"message": "Redeem codes deleted successfully",
|
||
})
|
||
}
|
||
|
||
// Expire handles expiring a redeem code
|
||
// POST /api/v1/admin/redeem-codes/:id/expire
|
||
func (h *RedeemHandler) Expire(c *gin.Context) {
|
||
codeID, err := strconv.ParseInt(c.Param("id"), 10, 64)
|
||
if err != nil {
|
||
response.BadRequest(c, "Invalid redeem code ID")
|
||
return
|
||
}
|
||
|
||
code, err := h.adminService.ExpireRedeemCode(c.Request.Context(), codeID)
|
||
if err != nil {
|
||
response.ErrorFrom(c, err)
|
||
return
|
||
}
|
||
|
||
response.Success(c, dto.RedeemCodeFromService(code))
|
||
}
|
||
|
||
// GetStats handles getting redeem code statistics
|
||
// GET /api/v1/admin/redeem-codes/stats
|
||
func (h *RedeemHandler) GetStats(c *gin.Context) {
|
||
// Return mock data for now
|
||
response.Success(c, gin.H{
|
||
"total_codes": 0,
|
||
"active_codes": 0,
|
||
"used_codes": 0,
|
||
"expired_codes": 0,
|
||
"total_value_distributed": 0.0,
|
||
"by_type": gin.H{
|
||
"balance": 0,
|
||
"concurrency": 0,
|
||
"trial": 0,
|
||
},
|
||
})
|
||
}
|
||
|
||
// Export handles exporting redeem codes to CSV
|
||
// GET /api/v1/admin/redeem-codes/export
|
||
func (h *RedeemHandler) Export(c *gin.Context) {
|
||
codeType := c.Query("type")
|
||
status := c.Query("status")
|
||
|
||
// Get all codes without pagination (use large page size)
|
||
codes, _, err := h.adminService.ListRedeemCodes(c.Request.Context(), 1, 10000, codeType, status, "")
|
||
if err != nil {
|
||
response.ErrorFrom(c, err)
|
||
return
|
||
}
|
||
|
||
// Create CSV buffer
|
||
var buf bytes.Buffer
|
||
writer := csv.NewWriter(&buf)
|
||
|
||
// Write header
|
||
if err := writer.Write([]string{"id", "code", "type", "value", "status", "used_by", "used_at", "created_at"}); err != nil {
|
||
response.InternalError(c, "Failed to export redeem codes: "+err.Error())
|
||
return
|
||
}
|
||
|
||
// Write data rows
|
||
for _, code := range codes {
|
||
usedBy := ""
|
||
if code.UsedBy != nil {
|
||
usedBy = fmt.Sprintf("%d", *code.UsedBy)
|
||
}
|
||
usedAt := ""
|
||
if code.UsedAt != nil {
|
||
usedAt = code.UsedAt.Format("2006-01-02 15:04:05")
|
||
}
|
||
if err := writer.Write([]string{
|
||
fmt.Sprintf("%d", code.ID),
|
||
code.Code,
|
||
code.Type,
|
||
fmt.Sprintf("%.2f", code.Value),
|
||
code.Status,
|
||
usedBy,
|
||
usedAt,
|
||
code.CreatedAt.Format("2006-01-02 15:04:05"),
|
||
}); err != nil {
|
||
response.InternalError(c, "Failed to export redeem codes: "+err.Error())
|
||
return
|
||
}
|
||
}
|
||
|
||
writer.Flush()
|
||
if err := writer.Error(); err != nil {
|
||
response.InternalError(c, "Failed to export redeem codes: "+err.Error())
|
||
return
|
||
}
|
||
|
||
c.Header("Content-Type", "text/csv")
|
||
c.Header("Content-Disposition", "attachment; filename=redeem_codes.csv")
|
||
c.Data(200, "text/csv", buf.Bytes())
|
||
}
|