erio
|
a9880ee7b9
|
fix: round-2 audit fixes — security, code quality, and UI improvements
Security (HIGH):
- Normalize all Redis cache keys to lowercase (verifyCode, passwordReset)
- Fix verify code TTL renewal on failed attempts: use remaining TTL via
ExpiresAt field instead of resetting to full 15-minute window
- Add 3 missing fields to diffSettings audit log (promo_code, invitation_code,
custom_endpoints)
Code quality (MEDIUM):
- Extract filterVerifiedEmails shared helper (balance_notify_service.go)
- Add Pricing array non-empty validation for channel pricing rules
- Add platform token semantics comment in gateway_service.go
- Complete validatePlanPatch test coverage (+10 test cases)
- Replace string types with QuotaThresholdType/QuotaResetMode across frontend
- Remove duplicate getPlatformTextColor/getRateBadgeClass in ChannelsView
- Return EMAIL_NOT_FOUND error on RemoveNotifyEmail miss
UI improvements:
- Reorder cost tooltip: user billing above separator, account billing below
- Add NaN guard to accountBilled function
- Move timezone selector inline into reset-mode row (no longer standalone)
|
2026-04-14 09:35:05 +08:00 |
|
erio
|
1b7c295199
|
refactor: M5 useQuotaNotifyState composable + H14 Vue file splits
M5: New composable frontend/src/composables/useQuotaNotifyState.ts
- Replaces 9 individual refs in both Create/Edit modals with reactive state
- Provides loadFromExtra/writeToExtra/reset helpers
- Eliminates ~120 lines of duplicated code across the two modals
H14: Vue file length violations fixed
- AdminPaymentPlansView.vue: 325 → 183 lines (extracted PlanEditDialog.vue)
- QuotaLimitCard.vue: 327 → 268 lines (extracted QuotaDimensionRow.vue)
- PlanEditDialog.vue: 181 lines (new, plan create/edit form)
- QuotaDimensionRow.vue: 108 lines (new, single quota dimension row)
|
2026-04-14 09:33:39 +08:00 |
|