oadmin/sub2api
1
0
Fork 0
Code Issues Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

fix(ci): 修复最后一批CI错误

Browse Source 
- 修复 ops_repo_trends.go 中剩余3处 Rows.Close 未检查错误
- 修复 ops_settings.go, ops_settings_models.go, ops_trends.go 的格式化问题
This commit is contained in:
IanShaw027
2026-01-12 00:02:19 +08:00
parent 19b67e89a2
commit c48795a948
4 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/internal/repository/ops_repo_trends.go
View File

@@ -265,7 +265,7 @@ LIMIT $4`
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer rows.Close() defer func() { _ = rows.Close() }()
items := make([]*service.OpsThroughputGroupBreakdownItem, 0, limit) items := make([]*service.OpsThroughputGroupBreakdownItem, 0, limit)
for rows.Next() { for rows.Next() {
@@ -431,7 +431,7 @@ ORDER BY 1 ASC`
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer rows.Close() defer func() { _ = rows.Close() }()
points := make([]*service.OpsErrorTrendPoint, 0, 256) points := make([]*service.OpsErrorTrendPoint, 0, 256)
for rows.Next() { for rows.Next() {
@@ -542,7 +542,7 @@ LIMIT 20`
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer rows.Close() defer func() { _ = rows.Close() }()
items := make([]*service.OpsErrorDistributionItem, 0, 16) items := make([]*service.OpsErrorDistributionItem, 0, 16)
var total int64 var total int64

7
backend/internal/service/ops_settings.go
View File

@@ -359,9 +359,9 @@ func (s *OpsService) UpdateOpsAlertRuntimeSettings(ctx context.Context, cfg *Ops
func defaultOpsAdvancedSettings() *OpsAdvancedSettings { func defaultOpsAdvancedSettings() *OpsAdvancedSettings {
return &OpsAdvancedSettings{ return &OpsAdvancedSettings{
DataRetention: OpsDataRetentionSettings{ DataRetention: OpsDataRetentionSettings{
CleanupEnabled: false, CleanupEnabled: false,
CleanupSchedule: "0 2 * * *", CleanupSchedule: "0 2 * * *",
ErrorLogRetentionDays: 30, ErrorLogRetentionDays: 30,
MinuteMetricsRetentionDays: 30, MinuteMetricsRetentionDays: 30,
HourlyMetricsRetentionDays: 30, HourlyMetricsRetentionDays: 30,
}, },
@@ -463,4 +463,3 @@ func (s *OpsService) UpdateOpsAdvancedSettings(ctx context.Context, cfg *OpsAdva
_ = json.Unmarshal(raw, updated) _ = json.Unmarshal(raw, updated)
return updated, nil return updated, nil
} }

11
backend/internal/service/ops_settings_models.go
View File

@@ -75,14 +75,13 @@ type OpsAdvancedSettings struct {
} }
type OpsDataRetentionSettings struct { type OpsDataRetentionSettings struct {
CleanupEnabled bool `json:"cleanup_enabled"` CleanupEnabled bool `json:"cleanup_enabled"`
CleanupSchedule string `json:"cleanup_schedule"` CleanupSchedule string `json:"cleanup_schedule"`
ErrorLogRetentionDays int `json:"error_log_retention_days"` ErrorLogRetentionDays int `json:"error_log_retention_days"`
MinuteMetricsRetentionDays int `json:"minute_metrics_retention_days"` MinuteMetricsRetentionDays int `json:"minute_metrics_retention_days"`
HourlyMetricsRetentionDays int `json:"hourly_metrics_retention_days"` HourlyMetricsRetentionDays int `json:"hourly_metrics_retention_days"`
} }
type OpsAggregationSettings struct { type OpsAggregationSettings struct {
AggregationEnabled bool `json:"aggregation_enabled"` AggregationEnabled bool `json:"aggregation_enabled"`
} }

1
backend/internal/service/ops_trends.go
View File

@@ -24,4 +24,3 @@ func (s *OpsService) GetThroughputTrend(ctx context.Context, filter *OpsDashboar
} }
return s.opsRepo.GetThroughputTrend(ctx, filter, bucketSeconds) return s.opsRepo.GetThroughputTrend(ctx, filter, bucketSeconds)
} }