🔧 fix(stream_scanner): improve resource management and error handling in StreamScannerHandler
This commit is contained in:
@@ -3,6 +3,7 @@ package helper
|
|||||||
import (
|
import (
|
||||||
"bufio"
|
"bufio"
|
||||||
"context"
|
"context"
|
||||||
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"net/http"
|
"net/http"
|
||||||
"one-api/common"
|
"one-api/common"
|
||||||
@@ -19,8 +20,8 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
const (
|
const (
|
||||||
InitialScannerBufferSize = 1 << 20 // 1MB (1*1024*1024)
|
InitialScannerBufferSize = 64 << 10 // 64KB (64*1024)
|
||||||
MaxScannerBufferSize = 10 << 20 // 10MB (10*1024*1024)
|
MaxScannerBufferSize = 10 << 20 // 10MB (10*1024*1024)
|
||||||
DefaultPingInterval = 10 * time.Second
|
DefaultPingInterval = 10 * time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -30,7 +31,12 @@ func StreamScannerHandler(c *gin.Context, resp *http.Response, info *relaycommon
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
defer resp.Body.Close()
|
// 确保响应体总是被关闭
|
||||||
|
defer func() {
|
||||||
|
if resp.Body != nil {
|
||||||
|
resp.Body.Close()
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
streamingTimeout := time.Duration(constant.StreamingTimeout) * time.Second
|
streamingTimeout := time.Duration(constant.StreamingTimeout) * time.Second
|
||||||
if strings.HasPrefix(info.UpstreamModelName, "o") {
|
if strings.HasPrefix(info.UpstreamModelName, "o") {
|
||||||
@@ -39,11 +45,12 @@ func StreamScannerHandler(c *gin.Context, resp *http.Response, info *relaycommon
|
|||||||
}
|
}
|
||||||
|
|
||||||
var (
|
var (
|
||||||
stopChan = make(chan bool, 2)
|
stopChan = make(chan bool, 3) // 增加缓冲区避免阻塞
|
||||||
scanner = bufio.NewScanner(resp.Body)
|
scanner = bufio.NewScanner(resp.Body)
|
||||||
ticker = time.NewTicker(streamingTimeout)
|
ticker = time.NewTicker(streamingTimeout)
|
||||||
pingTicker *time.Ticker
|
pingTicker *time.Ticker
|
||||||
writeMutex sync.Mutex // Mutex to protect concurrent writes
|
writeMutex sync.Mutex // Mutex to protect concurrent writes
|
||||||
|
wg sync.WaitGroup // 用于等待所有 goroutine 退出
|
||||||
)
|
)
|
||||||
|
|
||||||
generalSettings := operation_setting.GetGeneralSetting()
|
generalSettings := operation_setting.GetGeneralSetting()
|
||||||
@@ -57,13 +64,32 @@ func StreamScannerHandler(c *gin.Context, resp *http.Response, info *relaycommon
|
|||||||
pingTicker = time.NewTicker(pingInterval)
|
pingTicker = time.NewTicker(pingInterval)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// 改进资源清理,确保所有 goroutine 正确退出
|
||||||
defer func() {
|
defer func() {
|
||||||
|
// 通知所有 goroutine 停止
|
||||||
|
common.SafeSendBool(stopChan, true)
|
||||||
|
|
||||||
ticker.Stop()
|
ticker.Stop()
|
||||||
if pingTicker != nil {
|
if pingTicker != nil {
|
||||||
pingTicker.Stop()
|
pingTicker.Stop()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// 等待所有 goroutine 退出,最多等待5秒
|
||||||
|
done := make(chan struct{})
|
||||||
|
go func() {
|
||||||
|
wg.Wait()
|
||||||
|
close(done)
|
||||||
|
}()
|
||||||
|
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(5 * time.Second):
|
||||||
|
common.LogError(c, "timeout waiting for goroutines to exit")
|
||||||
|
}
|
||||||
|
|
||||||
close(stopChan)
|
close(stopChan)
|
||||||
}()
|
}()
|
||||||
|
|
||||||
scanner.Buffer(make([]byte, InitialScannerBufferSize), MaxScannerBufferSize)
|
scanner.Buffer(make([]byte, InitialScannerBufferSize), MaxScannerBufferSize)
|
||||||
scanner.Split(bufio.ScanLines)
|
scanner.Split(bufio.ScanLines)
|
||||||
SetEventStreamHeaders(c)
|
SetEventStreamHeaders(c)
|
||||||
@@ -73,35 +99,95 @@ func StreamScannerHandler(c *gin.Context, resp *http.Response, info *relaycommon
|
|||||||
|
|
||||||
ctx = context.WithValue(ctx, "stop_chan", stopChan)
|
ctx = context.WithValue(ctx, "stop_chan", stopChan)
|
||||||
|
|
||||||
// Handle ping data sending
|
// Handle ping data sending with improved error handling
|
||||||
if pingEnabled && pingTicker != nil {
|
if pingEnabled && pingTicker != nil {
|
||||||
|
wg.Add(1)
|
||||||
gopool.Go(func() {
|
gopool.Go(func() {
|
||||||
|
defer func() {
|
||||||
|
wg.Done()
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
common.LogError(c, fmt.Sprintf("ping goroutine panic: %v", r))
|
||||||
|
common.SafeSendBool(stopChan, true)
|
||||||
|
}
|
||||||
|
if common.DebugEnabled {
|
||||||
|
println("ping goroutine exited")
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
|
// 添加超时保护,防止 goroutine 无限运行
|
||||||
|
maxPingDuration := 30 * time.Minute // 最大 ping 持续时间
|
||||||
|
pingTimeout := time.NewTimer(maxPingDuration)
|
||||||
|
defer pingTimeout.Stop()
|
||||||
|
|
||||||
for {
|
for {
|
||||||
select {
|
select {
|
||||||
case <-pingTicker.C:
|
case <-pingTicker.C:
|
||||||
writeMutex.Lock() // Lock before writing
|
// 使用超时机制防止写操作阻塞
|
||||||
err := PingData(c)
|
done := make(chan error, 1)
|
||||||
writeMutex.Unlock() // Unlock after writing
|
go func() {
|
||||||
if err != nil {
|
writeMutex.Lock()
|
||||||
common.LogError(c, "ping data error: "+err.Error())
|
defer writeMutex.Unlock()
|
||||||
common.SafeSendBool(stopChan, true)
|
done <- PingData(c)
|
||||||
|
}()
|
||||||
|
|
||||||
|
select {
|
||||||
|
case err := <-done:
|
||||||
|
if err != nil {
|
||||||
|
common.LogError(c, "ping data error: "+err.Error())
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if common.DebugEnabled {
|
||||||
|
println("ping data sent")
|
||||||
|
}
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
common.LogError(c, "ping data send timeout")
|
||||||
|
return
|
||||||
|
case <-ctx.Done():
|
||||||
|
return
|
||||||
|
case <-stopChan:
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if common.DebugEnabled {
|
|
||||||
println("ping data sent")
|
|
||||||
}
|
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
if common.DebugEnabled {
|
return
|
||||||
println("ping data goroutine stopped")
|
case <-stopChan:
|
||||||
}
|
return
|
||||||
|
case <-c.Request.Context().Done():
|
||||||
|
// 监听客户端断开连接
|
||||||
|
return
|
||||||
|
case <-pingTimeout.C:
|
||||||
|
common.LogError(c, "ping goroutine max duration reached")
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Scanner goroutine with improved error handling
|
||||||
|
wg.Add(1)
|
||||||
common.RelayCtxGo(ctx, func() {
|
common.RelayCtxGo(ctx, func() {
|
||||||
|
defer func() {
|
||||||
|
wg.Done()
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
common.LogError(c, fmt.Sprintf("scanner goroutine panic: %v", r))
|
||||||
|
}
|
||||||
|
common.SafeSendBool(stopChan, true)
|
||||||
|
if common.DebugEnabled {
|
||||||
|
println("scanner goroutine exited")
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
for scanner.Scan() {
|
for scanner.Scan() {
|
||||||
|
// 检查是否需要停止
|
||||||
|
select {
|
||||||
|
case <-stopChan:
|
||||||
|
return
|
||||||
|
case <-ctx.Done():
|
||||||
|
return
|
||||||
|
case <-c.Request.Context().Done():
|
||||||
|
return
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
|
||||||
ticker.Reset(streamingTimeout)
|
ticker.Reset(streamingTimeout)
|
||||||
data := scanner.Text()
|
data := scanner.Text()
|
||||||
if common.DebugEnabled {
|
if common.DebugEnabled {
|
||||||
@@ -119,11 +205,27 @@ func StreamScannerHandler(c *gin.Context, resp *http.Response, info *relaycommon
|
|||||||
data = strings.TrimSuffix(data, "\r")
|
data = strings.TrimSuffix(data, "\r")
|
||||||
if !strings.HasPrefix(data, "[DONE]") {
|
if !strings.HasPrefix(data, "[DONE]") {
|
||||||
info.SetFirstResponseTime()
|
info.SetFirstResponseTime()
|
||||||
writeMutex.Lock() // Lock before writing
|
|
||||||
success := dataHandler(data)
|
// 使用超时机制防止写操作阻塞
|
||||||
writeMutex.Unlock() // Unlock after writing
|
done := make(chan bool, 1)
|
||||||
if !success {
|
go func() {
|
||||||
break
|
writeMutex.Lock()
|
||||||
|
defer writeMutex.Unlock()
|
||||||
|
done <- dataHandler(data)
|
||||||
|
}()
|
||||||
|
|
||||||
|
select {
|
||||||
|
case success := <-done:
|
||||||
|
if !success {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
case <-time.After(10 * time.Second):
|
||||||
|
common.LogError(c, "data handler timeout")
|
||||||
|
return
|
||||||
|
case <-ctx.Done():
|
||||||
|
return
|
||||||
|
case <-stopChan:
|
||||||
|
return
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -133,17 +235,18 @@ func StreamScannerHandler(c *gin.Context, resp *http.Response, info *relaycommon
|
|||||||
common.LogError(c, "scanner error: "+err.Error())
|
common.LogError(c, "scanner error: "+err.Error())
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
common.SafeSendBool(stopChan, true)
|
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// 主循环等待完成或超时
|
||||||
select {
|
select {
|
||||||
case <-ticker.C:
|
case <-ticker.C:
|
||||||
// 超时处理逻辑
|
// 超时处理逻辑
|
||||||
common.LogError(c, "streaming timeout")
|
common.LogError(c, "streaming timeout")
|
||||||
common.SafeSendBool(stopChan, true)
|
|
||||||
case <-stopChan:
|
case <-stopChan:
|
||||||
// 正常结束
|
// 正常结束
|
||||||
common.LogInfo(c, "streaming finished")
|
common.LogInfo(c, "streaming finished")
|
||||||
|
case <-c.Request.Context().Done():
|
||||||
|
// 客户端断开连接
|
||||||
|
common.LogInfo(c, "client disconnected")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -68,8 +68,8 @@ func getTokenNum(tokenEncoder tokenizer.Codec, text string) int {
|
|||||||
if text == "" {
|
if text == "" {
|
||||||
return 0
|
return 0
|
||||||
}
|
}
|
||||||
ids, _, _ := tokenEncoder.Encode(text)
|
tkm, _ := tokenEncoder.Count(text)
|
||||||
return len(ids)
|
return tkm
|
||||||
}
|
}
|
||||||
|
|
||||||
func getImageToken(info *relaycommon.RelayInfo, imageUrl *dto.MessageImageUrl, model string, stream bool) (int, error) {
|
func getImageToken(info *relaycommon.RelayInfo, imageUrl *dto.MessageImageUrl, model string, stream bool) (int, error) {
|
||||||
|
|||||||
Reference in New Issue
Block a user