From d595ef499070cc4156444a12d6d864e509598ec7 Mon Sep 17 00:00:00 2001 From: "zhongyuan.zhao" Date: Wed, 18 Mar 2026 15:57:56 +0800 Subject: [PATCH] fix(waffo): remove dead gatewayOrderId code that never persisted The code read orderData.AcquiringOrderID but never assigned it to any TopUp field before calling Update(), making the block a no-op. Removed since GatewayOrderId storage is not needed. Co-Authored-By: Claude Opus 4.6 (1M context) --- controller/topup_waffo.go | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/controller/topup_waffo.go b/controller/topup_waffo.go index d78bb314..fce37642 100644 --- a/controller/topup_waffo.go +++ b/controller/topup_waffo.go @@ -255,17 +255,6 @@ func RequestWaffoPay(c *gin.Context) { orderData := resp.GetData() log.Printf("Waffo 订单创建成功 - 用户: %d, 订单: %s, 金额: %.2f", id, merchantOrderId, payMoney) - // 存储 gatewayOrderId，退款时直接使用；保存失败则中止，避免付款后无法退款 - if orderData.AcquiringOrderID != "" { - if err := topUp.Update(); err != nil { - log.Printf("Waffo 保存 gatewayOrderId 失败: %v, 订单: %s", err, merchantOrderId) - topUp.Status = common.TopUpStatusFailed - _ = topUp.Update() - c.JSON(200, gin.H{"message": "error", "data": "创建订单失败，请重试"}) - return - } - } - paymentUrl := orderData.FetchRedirectURL() if paymentUrl == "" { paymentUrl = orderData.OrderAction